Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flat-manager: Add 'end-of-life' and 'end-of-life-rebase' inputs #71

Merged
merged 18 commits into from
Jan 9, 2022
Merged

flat-manager: Add 'end-of-life' and 'end-of-life-rebase' inputs #71

merged 18 commits into from
Jan 9, 2022

Conversation

meisenzahl
Copy link
Contributor

@meisenzahl meisenzahl commented Jan 9, 2022 •
edited
Loading

Related to elementary/appcenter-reviews#293

TL;DR

There may come a point where an application is no longer maintained. In order to inform users at update or install time that it will no longer get updates.

If the application has been renamed, you can additionally include end-of-life-rebase with the new ID. Recent flatpak versions will prompt user if they'd like to switch to the renamed app.

Source: https://github.com/flathub/flathub/wiki/App-Maintenance#end-of-life

@meisenzahl meisenzahl mentioned this pull request Jan 9, 2022
Closed
@meisenzahl meisenzahl changed the title flatpak-builder: Add 'end-of-life' and 'end-of-life-rebase' inputs flat-manager: Add 'end-of-life' and 'end-of-life-rebase' inputs Jan 9, 2022
@meisenzahl meisenzahl marked this pull request as ready for review January 9, 2022 07:06
@bilelmoussaoui
Copy link
Member

Also you need to rebuild the action so that it works, see https://github.com/bilelmoussaoui/flatpak-github-actions/blob/master/CONTRIBUTING.md#prerequisites

@meisenzahl
Copy link
Contributor Author

@bilelmoussaoui thank you for your feedback! I hope I have taken all the comments into account.

bilelmoussaoui
bilelmoussaoui reviewed Jan 9, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
bilelmoussaoui
bilelmoussaoui reviewed Jan 9, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
bilelmoussaoui
bilelmoussaoui requested changes Jan 9, 2022
View reviewed changes
Copy link
Member

@bilelmoussaoui bilelmoussaoui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please make the lint job happy

flat-manager/action.yml Outdated Show resolved Hide resolved
@bilelmoussaoui bilelmoussaoui merged commit 1583e7a into flatpak:master Jan 9, 2022
@bilelmoussaoui
Copy link
Member

Thank you for your contribution! there are still some minor things I would like to see changed in the code but I will handle those myself

@meisenzahl
Copy link
Contributor Author

@bilelmoussaoui thank you for your feedback and your patience with me.

@meisenzahl meisenzahl deleted the flatpak-builder-add-end-of-life-input branch January 9, 2022 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bilelmoussaoui bilelmoussaoui bilelmoussaoui requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meisenzahl @bilelmoussaoui